[Buildbot-devel] test_waterfall failure on win32

[Nick Trout]

> I'm
> still having issues with test_waterfall in test_web. The tests up
until
> the following one seem to work fine.

Ah. I appear to have fixed this one. It wasn't a problem with Twisted,
but with win32 path names and access modes.

Test_waterfall works on win32 if you replace line 174 with:

	cfg = config1 % os.path.abspath(favicon).replace('\\', '/')

ie. the os.path.abspath() call normalises the path and replaces all
forward slashes with back slashes. If this is formatted the backslashes
wipe out the following character etc. Not sure what to do about this one
for posix. Assuming there are no backslashes in any paths the "replace"
can't do any harm.

Around line 193 you need to open the expected icon file as a binary
file:

	expected = open(favicon,"rb").read()

I still appear to have some other problems, but that fixes that this
test. I thought for a while I was going to have to get my hands dirty in
Twisted so that's a relief.

Nick