[Buildbot-commits] [buildbot/buildbot] 61a7ac: wait for the logs are created before finishing the...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot
  Commit: 61a7ac85c748414c73a7109cbfee192a34e38016
      https://github.com/buildbot/buildbot/commit/61a7ac85c748414c73a7109cbfee192a34e38016
  Author: Pierre Tardy <pierre.tardy at intel.com>
  Date:   2014-10-26 (Sun, 26 Oct 2014)

  Changed paths:
    M master/buildbot/process/buildstep.py

  Log Message:
  -----------
  wait for the logs are created before finishing the step

There is a race condition between addLogs calls, and the end of the step.

for oldStyleSteps, this matters, because the subsequent addStderr, are only called
at the end of the step, so we must wait for log are created before continuing

Signed-off-by: Pierre Tardy <pierre.tardy at intel.com>


  Commit: 4721f5468705e2f303215c12fd46adf8a4b54240
      https://github.com/buildbot/buildbot/commit/4721f5468705e2f303215c12fd46adf8a4b54240
  Author: Pierre Tardy <pierre.tardy at intel.com>
  Date:   2014-10-27 (Mon, 27 Oct 2014)

  Changed paths:
    M master/buildbot/test/integration/test_custom_buildstep.py

  Log Message:
  -----------
  integration test for trac #2951

add a test for the case which the db is too slow to complete the newLog before end of the step

if I revert previous commit, I get the error reported by benallard

===============================================================================
[ERROR]
Traceback (most recent call last):
  File "/Users/ptardy/dev/bb/buildbot-heroku/buildbot/master/buildbot/process/buildstep.py", line 157, in next
    self._catchup()
  File "/Users/ptardy/dev/bb/buildbot-heroku/buildbot/master/buildbot/process/buildstep.py", line 159, in _catchup
    self.step._start_unhandled_deferreds.append(d)
exceptions.AttributeError: 'NoneType' object has no attribute 'append'

buildbot.test.integration.test_custom_buildstep.RunSteps.test_OldStyleCustomBuildStepSlowDB
buildbot.test.integration.test_custom_buildstep.RunSteps.test_OldStyleCustomBuildStepSlowDB
===============================================================================
[ERROR]
Traceback (most recent call last):
  File "/Users/ptardy/dev/bb/buildbot-heroku/buildbot/master/buildbot/process/buildstep.py", line 135, in gotAsync
    self._catchup()
  File "/Users/ptardy/dev/bb/buildbot-heroku/buildbot/master/buildbot/process/buildstep.py", line 159, in _catchup
    self.step._start_unhandled_deferreds.append(d)
exceptions.AttributeError: 'NoneType' object has no attribute 'append'

buildbot.test.integration.test_custom_buildstep.RunSteps.test_OldStyleCustomBuildStepSlowDB

Signed-off-by: Pierre Tardy <pierre.tardy at intel.com>


  Commit: 4bd5b1f0fca52b6842d92e56df62958c78c3d958
      https://github.com/buildbot/buildbot/commit/4bd5b1f0fca52b6842d92e56df62958c78c3d958
  Author: Dustin J. Mitchell <dustin at buildbot.net>
  Date:   2014-10-28 (Tue, 28 Oct 2014)

  Changed paths:
    M master/buildbot/process/buildstep.py
    M master/buildbot/test/integration/test_custom_buildstep.py

  Log Message:
  -----------
  use a hook, rather than time, in the tests


  Commit: fc2e28c7d2122113d3d0c4c1a6c9fe1b26a07e8a
      https://github.com/buildbot/buildbot/commit/fc2e28c7d2122113d3d0c4c1a6c9fe1b26a07e8a
  Author: Pierre Tardy <pierre.tardy at intel.com>
  Date:   2014-10-28 (Tue, 28 Oct 2014)

  Changed paths:
    M master/buildbot/process/buildstep.py

  Log Message:
  -----------
  run the hook only in non optimized mode

Signed-off-by: Pierre Tardy <pierre.tardy at intel.com>


  Commit: dae7c83eace772aa9d04b0fd6dd52b7879caecb6
      https://github.com/buildbot/buildbot/commit/dae7c83eace772aa9d04b0fd6dd52b7879caecb6
  Author: Mikhail Sobolev <mss at mawhrin.net>
  Date:   2014-10-28 (Tue, 28 Oct 2014)

  Changed paths:
    M master/buildbot/process/buildstep.py
    M master/buildbot/test/integration/test_custom_buildstep.py

  Log Message:
  -----------
  Merge pull request #1296 from tardyp/t2951

fix for ticket:2951: wait for the logs are created before finishing the step


Compare: https://github.com/buildbot/buildbot/compare/c1acde4702d4...dae7c83eace7