[Buildbot-commits] [buildbot/buildbot] a4658c: Rename the 'path' argument of the MasterShellComma...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot
  Commit: a4658cd3744381885b32a7472d5fb54019f9a04f
      https://github.com/buildbot/buildbot/commit/a4658cd3744381885b32a7472d5fb54019f9a04f
  Author: Benoît Allard <benoit.allard at gmx.de>
  Date:   2014-10-26 (Sun, 26 Oct 2014)

  Changed paths:
    M master/buildbot/steps/master.py
    M master/buildbot/test/unit/test_steps_master.py

  Log Message:
  -----------
  Rename the 'path' argument of the MasterShellCommand 'workdir'


  Commit: 35663dfde45e300f9cc5a8422bd6a03345d35d2e
      https://github.com/buildbot/buildbot/commit/35663dfde45e300f9cc5a8422bd6a03345d35d2e
  Author: Benoît Allard <benoit.allard at gmx.de>
  Date:   2014-10-27 (Mon, 27 Oct 2014)

  Changed paths:
    M master/buildbot/test/unit/test_steps_master.py

  Log Message:
  -----------
  Make the tests more realistic


  Commit: c81496dd5d9b9c289c6a09176b2da25be7225d97
      https://github.com/buildbot/buildbot/commit/c81496dd5d9b9c289c6a09176b2da25be7225d97
  Author: Benoît Allard <benoit.allard at gmx.de>
  Date:   2014-10-27 (Mon, 27 Oct 2014)

  Changed paths:
    M master/docs/manual/cfg-buildsteps.rst
    M master/docs/relnotes/index.rst

  Log Message:
  -----------
  Update doc and release note


  Commit: c1acde4702d41ced1d49ea15d2a37709326db6ca
      https://github.com/buildbot/buildbot/commit/c1acde4702d41ced1d49ea15d2a37709326db6ca
  Author: Mikhail Sobolev <mss at mawhrin.net>
  Date:   2014-10-28 (Tue, 28 Oct 2014)

  Changed paths:
    M master/buildbot/steps/master.py
    M master/buildbot/test/unit/test_steps_master.py
    M master/docs/manual/cfg-buildsteps.rst
    M master/docs/relnotes/index.rst

  Log Message:
  -----------
  Merge pull request #1295 from benallard/mastershell_workdir

Rename the 'path' argument of the MasterShellCommand 'workdir'

- All other steps take a workdir
- The path argument is not mentioned in the doc
  - Even worse, the doc has an example: command="cd dir; do stuff"
- As the test show, the one that wrote it believed it would become the PATH.


Compare: https://github.com/buildbot/buildbot/compare/35f3e8efaa9f...c1acde4702d4