[Buildbot-commits] [Buildbot] #2454: SiGHUP doesn't always work

[Buildbot]

#2454: SiGHUP doesn't always work
--------------------+------------------------
Reporter:  virgilg  |       Owner:
    Type:  defect   |      Status:  new
Priority:  major    |   Milestone:  undecided
 Version:  0.8.7p1  |  Resolution:
Keywords:           |
--------------------+------------------------

Comment (by dustin):

 Are you sure the SIGHUP is being delivered to the correct process?

 The only other thing I can think of is that the eventual loop is broken.
 Can you try

 {{{
 #!patch
 diff --git a/master/buildbot/util/eventual.py
 b/master/buildbot/util/eventual.py
 index 15fba6c..764e740 100644
 --- a/master/buildbot/util/eventual.py
 +++ b/master/buildbot/util/eventual.py
 @@ -30,6 +30,7 @@ class _SimpleCallQueue(object):
          self._in_turn = False

      def append(self, cb, args, kwargs):
 +        print "EV append", cb
          self._events.append((cb, args, kwargs))
          if not self._timer:
              self._timer = self._reactor.callLater(0, self._turn)
 @@ -42,6 +43,7 @@ class _SimpleCallQueue(object):
          # be put off until the next turn.
          events, self._events = self._events, []
          for cb, args, kwargs in events:
 +            print "EV call", cb
              try:
                  cb(*args, **kwargs)
              except:
 @@ -65,6 +67,7 @@ class _SimpleCallQueue(object):
  _theSimpleQueue = _SimpleCallQueue()

  def eventually(cb, *args, **kwargs):
 +    print "EV eventually", cb
      _theSimpleQueue.append(cb, args, kwargs)


 }}}

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2454#comment:3>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation