[Buildbot-commits] [Buildbot] #1064: Logging ChangeFilter checks

Buildbot trac trac at buildbot.net
Sat Aug 24 05:19:34 UTC 2013


#1064: Logging ChangeFilter checks
----------------------------+--------------------
Reporter:  strk             |       Owner:
    Type:  enhancement      |      Status:  new
Priority:  major            |   Milestone:  0.8.+
 Version:  0.8.2            |  Resolution:
Keywords:  sprint, logging  |
----------------------------+--------------------

Comment (by dcoshea):

 If I create a !ChangeFilter with only filter_fn set, then all that the
 proposed logging code sitting outside of my function could indicate was
 what the content of the Change object was and whether my function returned
 True or False.  I've put a few "print" statements in my filter function so
 I can work out ''why'' it is returning True or False.  When this verbose
 logging is added, would it make sense to make the logging object available
 to the filter_fn so my logging could be tied in with the standard logging?

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1064#comment:7>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation


More information about the Commits mailing list