[Buildbot-commits] [Buildbot] #956: Send an email notification to the person who forces/rebuilds a build
Buildbot trac
trac at buildbot.net
Sat Aug 24 05:14:31 UTC 2013
#956: Send an email notification to the person who forces/rebuilds a build
------------------------+--------------------
Reporter: yogawa@… | Owner:
Type: enhancement | Status: new
Priority: major | Milestone: 0.8.+
Version: 0.8.1 | Resolution:
Keywords: mail, users |
------------------------+--------------------
Comment (by dcoshea):
Replying to [comment:4 jaredgrubb]:
> Buildbot does this if you have the MailNotifier send to "interested
users".. or am I missing what this bug is about?
If I set the !MailNotifier's mode=!["failing"], then the user that forced
the build will only get mail if the forced build fails. I think the issue
is not that Buildbot doesn't behave as documented, just that users (at
least some I have spoken to) expect that forced/try builds should be
different from automatically-scheduled builds, in that the interested user
should get mail whether or not the forced/try build failed, whereas they
don't want an email for every successful automatically-scheduled build.
I've considered subclassing !MailNotifier and overriding isMailNeeded() to
include this kind of logic, as I don't think that just adding another mode
such as "force" would address all my user's requirements - I basically
need to send email for failing builds on ''some'' builders, but send
emails for all force/try builds on ''all'' builders. A slightly nicer
option would be to add a parameter to the !MailNotifier that accepts a
predicate function indicating whether or not mail should be sent.
--
Ticket URL: <http://trac.buildbot.net/ticket/956#comment:6>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation
More information about the Commits
mailing list