[Buildbot-commits] [Buildbot] #2022: Stale Broker errors not caught on reconfig

[Buildbot]

#2022: Stale Broker errors not caught on reconfig
---------------------+--------------------
Reporter:  dustin    |       Owner:
    Type:  defect    |      Status:  new
Priority:  major     |   Milestone:  0.8.5
 Version:  0.8.2     |  Resolution:
Keywords:  reconfig  |
---------------------+--------------------

Comment (by dustin):

 So {{{setBuilderList}}} is not the culprit here - the pinging of the old
 slave is the culprit.  The new {{{DuplicateSlaveArbitrator}}} *tries* to
 handle this, but sadly {{{callRemote}}} sometimes raises an exception
 instead of returning a failing Deferred.

 {{{
 #!python
         d = self.old_slave.slave.callRemote("print",
             "master got a duplicate connection from %s; keeping this one"
 % new_peer)
 }}}

 the deferred has errbacks attached to it, so we need to arrange for those
 to be called for an exception, too -- easily done with
 {{{defer.maybeDeferred}}}.

 However, this should have some testing (how?), as I don't particularly
 trust the code in start_new_slave that tries to call {{{loseConnection}}}
 on the old slave, but never actually calls its {{{detached}}} method.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2022#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation