[Buildbot-commits] [Buildbot] #2022: Stale Broker errors not caught on reconfig

[Buildbot]

#2022: Stale Broker errors not caught on reconfig
---------------------+--------------------
Reporter:  dustin    |       Owner:
    Type:  defect    |      Status:  new
Priority:  major     |   Milestone:  0.8.5
 Version:  0.8.2     |  Resolution:
Keywords:  reconfig  |
---------------------+--------------------

Comment (by dustin):

 So this does not appear to be the case.

 {{{
 #!python
 class BuildSlave(AbstractBuildSlave):

     def sendBuilderList(self):
         d = AbstractBuildSlave.sendBuilderList(self)
         def _sent(slist):
             # Nothing has changed, so don't need to re-attach to
 everything
             if not slist:
                 return
             dl = []
             for name, remote in slist.items():
                 # use get() since we might have changed our mind since
 then
                 b = self.botmaster.builders.get(name)
                 if b:
                     d1 = b.attached(self, remote, self.slave_commands)
                     dl.append(d1)
             return defer.DeferredList(dl)
         def _set_failed(why):
             log.msg("BuildSlave.sendBuilderList (%s) failed" % self)
             log.err(why)
             # TODO: hang up on them?, without setBuilderList we can't use
             # them
         d.addCallbacks(_sent, _set_failed)
         return d
 }}}

 so the {{{sendBuilderList}}} call itself is adequately protected against
 failures, and the Deferred it returns will never errback.

 I also can't reproduce this either by fiddling with things to raise
 Failures at the right point, or by repeatedly reconfig'ing a master while
 killing and restarting a slave.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/2022#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation