[Buildbot-commits] [buildbot/buildbot] 90da4d: Make all getProperties calls use the same signatur...

[noreply at github.com]

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot

  Commit: 90da4d9b7b2f0e0a77a9d61ca845bf98cac128a1
      https://github.com/buildbot/buildbot/commit/90da4d9b7b2f0e0a77a9d61ca845bf98cac128a1
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-17 (Sun, 17 Jul 2011)

  Changed paths:
    M master/buildbot/interfaces.py
  M master/buildbot/process/buildstep.py
  M master/buildbot/process/mtrlogobserver.py
  M master/buildbot/process/properties.py
  M master/buildbot/status/status_gerrit.py
  M master/buildbot/status/web/base.py
  M master/buildbot/status/web/build.py
  M master/buildbot/status/web/builder.py
  M master/buildbot/status/web/console.py
  M master/buildbot/status/web/feeds.py
  M master/buildbot/steps/shell.py
  M master/buildbot/steps/source/oldsource.py
  A master/buildbot/test/fake/fakebuild.py
  M master/buildbot/test/unit/test_process_buildstep.py
  M master/buildbot/test/unit/test_process_properties.py
  M master/buildbot/test/util/steps.py

  Log Message:
  -----------
  Make all getProperties calls use the same signature

This fixes the remaining implementations of getProperty that still
raised KeyError (a la dict.__getitem__) instead of returning a default
value (a la dict.get): IBuildStatus (which was simply incorrect) and
BuildStep (which now uses PropertiesMixin).

All uses of getProperties are cleaned up to expect None on a missing
property, rather than KeyError.

Fixes #2052.