[Buildbot-commits] [buildbot/buildbot] 24047d: Merge pull request #184 from tomprince/source

noreply at github.com noreply at github.com
Mon Jul 18 02:18:53 UTC 2011


  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot

  Commit: 24047dba6338a084b628ccedf5cff63fcfe59d51
      https://github.com/buildbot/buildbot/commit/24047dba6338a084b628ccedf5cff63fcfe59d51
  Author: Dustin J. Mitchell <dustin at v.igoro.us>
  Date:   2011-07-17 (Sun, 17 Jul 2011)

  Changed paths:
    M master/buildbot/steps/source/git.py
  M master/buildbot/steps/source/mercurial.py

  Log Message:
  -----------
  Merge pull request #184 from tomprince/source

Get rid of _ComputeRepositoryURL from new source steps.

>From Tom's description of the pull request:

The reason for this is that _ComputeRepositoryURL has a bunch of magic to be backwards compatible with a bunch of different ways of specifying the repository. With the new renderable support, one can write code to explicitly specify any of the behaviours exposed by _ComputeRepositoryURL, with out relying on the right backwards compatibility code. I thought since we are not making the new steps entirely compatible with the old ones, it would be a good chance to get rid of the backwards compatibility magic in _ComputeRepositoryURL.






More information about the Commits mailing list