[Buildbot-commits] [Buildbot] #1036: buildrequest can be multiply claimed on MySQL
Buildbot
nobody at buildbot.net
Sun Jul 17 17:48:20 UTC 2011
#1036: buildrequest can be multiply claimed on MySQL
---------------------+---------------------
Reporter: dustin | Owner:
Type: defect | Status: closed
Priority: blocker | Milestone: 0.8.5
Version: 0.8.1 | Resolution: fixed
Keywords: database |
---------------------+---------------------
Changes (by Dustin J. Mitchell):
* status: new => closed
* resolution: => fixed
Comment:
Use atomic inserts to claim build requests
This differs from the previous practice of trying to update rows to
reflect a claim, which is not possible in an atomic fashion across all
database engines. This brings a few non-compatible changes:
The db.buildrequests.claimBuildRequests method can no longer re-claim
already-claimed requests; use reclaimBuildRequests instead. The
database no longer tracks master instances, so the
unclaimOldIncarnationRequests method has been removed. Note that
several of the methods in this module now perform fewer consistency
checks, for efficiency.
Requests are now claimed to a particular master, but not to a particular
"incarnation" of that master. The identity of the master is drawn from
the existing objects table.
This commit upgrades the database to version 11. Fixes #1036.
Changeset: 8b1cee84683fd185d46aea193a01f2b42b4f5503
--
Ticket URL: <http://trac.buildbot.net/ticket/1036#comment:6>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation
More information about the Commits
mailing list