[Buildbot-commits] [buildbot/buildbot] 8b1cee: Use atomic inserts to claim build requests

[noreply at github.com]

  Branch: refs/heads/master
  Home:   https://github.com/buildbot/buildbot

  Commit: 8b1cee84683fd185d46aea193a01f2b42b4f5503
      https://github.com/buildbot/buildbot/commit/8b1cee84683fd185d46aea193a01f2b42b4f5503
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-17 (Sun, 17 Jul 2011)

  Changed paths:
    M master/NEWS
  M master/buildbot/db/buildrequests.py
  A master/buildbot/db/migrate/versions/011_add_buildrequest_claims.py
  M master/buildbot/db/model.py
  M master/buildbot/master.py
  M master/buildbot/process/builder.py
  M master/buildbot/test/fake/fakedb.py
  M master/buildbot/test/fake/fakemaster.py
  M master/buildbot/test/integration/test_upgrade.py
  M master/buildbot/test/unit/test_db_buildrequests.py
  M master/buildbot/test/unit/test_db_buildsets.py
  M master/buildbot/test/unit/test_master.py
  M master/buildbot/test/unit/test_process_builder.py
  M master/buildbot/test/unit/test_schedulers_basic.py
  M master/buildbot/test/unit/test_status_mail.py
  M master/buildbot/test/util/db.py
  A master/buildbot/util/sautils.py

  Log Message:
  -----------
  Use atomic inserts to claim build requests

This differs from the previous practice of trying to update rows to
reflect a claim, which is not possible in an atomic fashion across all
database engines.  This brings a few non-compatible changes:

The db.buildrequests.claimBuildRequests method can no longer re-claim
already-claimed requests; use reclaimBuildRequests instead.  The
database no longer tracks master instances, so the
unclaimOldIncarnationRequests method has been removed.  Note that
several of the methods in this module now perform fewer consistency
checks, for efficiency.

Requests are now claimed to a particular master, but not to a particular
"incarnation" of that master.  The identity of the master is drawn from
the existing objects table.

This commit upgrades the database to version 11.  Fixes #1036.


  Commit: 7918ef351cd1aa406036523d0b9a4af7cfade29a
      https://github.com/buildbot/buildbot/commit/7918ef351cd1aa406036523d0b9a4af7cfade29a
  Author: Dustin J. Mitchell <dustin at mozilla.com>
  Date:   2011-07-17 (Sun, 17 Jul 2011)

  Changed paths:
    M master/buildbot/db/state.py
  M master/buildbot/test/fake/fakemaster.py

  Log Message:
  -----------
  Test that cached db values are weakref-able


Compare: https://github.com/buildbot/buildbot/compare/5fa1f10...7918ef3