[Buildbot-commits] [Buildbot] #1764: buildbot reconfig command doesn't restart MailNotifier (was: buildbot restart command doesn't restart MailNotifier)

[Buildbot]

#1764: buildbot reconfig command doesn't restart MailNotifier
--------------------+--------------------
Reporter:  akevan   |       Owner:
    Type:  defect   |      Status:  new
Priority:  minor    |   Milestone:  0.8.4
 Version:  0.8.3p1  |  Resolution:
Keywords:           |
--------------------+--------------------
Changes (by dustin):

 * keywords:  MailNotifier  restart messageFormatter =>
 * milestone:  undecided => 0.8.4


Old description:

> The 'restart' command doesn't function the same as issuing a stop and
> start command separately. This was noticed with the messageFormatter
> passed into MailNotifier.
>
> Steps to repro:
> 1. Setup a MailNotifier, without a messageFormatter
> 2. Start the bot
> 3. Force a build
> 4. Receive the default mail notification
> 5. change master.cfg by adding a mail notifier function, and adding it to
> the MailNotifier c'tor
> 6. issue a 'restart' command on the buildbot
> 7. Force another build
> 8. Receive the same default mail notification :(
>
> Workaround is to issue 'stop' then 'start' commands separately. The
> MailNotifier then uses the requested message formatter.

New description:

 The 'restart' command doesn't function the same as issuing a stop and
 start command separately. This was noticed with the messageFormatter
 passed into MailNotifier.

 Steps to repro:
 1. Setup a MailNotifier, without a messageFormatter
 2. Start the bot
 3. Force a build
 4. Receive the default mail notification
 5. change master.cfg by adding a mail notifier function, and adding it to
 the MailNotifier c'tor
 6. issue a 'reconfig' command on the buildbot
 7. Force another build
 8. Receive the same default mail notification :(

 Workaround is to use the 'restart' command instead. The MailNotifier then
 uses the requested message formatter.

--

Comment:

 I strongly suspect you mean "reconfig" rather than "restart", as a restart
 really is a 'stop' followed by a 'start'.  To check, I tried a restart and
 found that it does, in fact, recognize the new configuration file.

 Still, it should be fixed.  Summary/description adjusted accordingly.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1764#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation