[Buildbot-commits] [Buildbot] #1765: rm -rf always run even if there is nothing to delete

[Buildbot]

#1765: rm -rf always run even if there is nothing to delete
------------------------+-----------------------
Reporter:  fgsch        |      Owner:
    Type:  enhancement  |     Status:  new
Priority:  minor        |  Milestone:  undecided
 Version:  0.8.3p1      |   Keywords:
------------------------+-----------------------
 In buildslave/commands/base.py's SourceBaseCommand, in start there is a
 check to find out whether the directory can be updated:

         if not (self.sourcedirIsUpdateable() and
 self.sourcedataMatches()):

 self.srcdir might not exist so this condition will be true and the command
 will be executed when it's not necessary. It's a bit confusing to see this
 in the logs so although harmless it'd be better to check if the directory
 exists before.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1765>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation