[Buildbot-commits] [Buildbot] #1756: "New Ticket" fails with an unhelpful error message

[Buildbot]

#1756: "New Ticket" fails with an unhelpful error message
------------------------+----------------------
Reporter:  sjl          |       Owner:
    Type:  enhancement  |      Status:  closed
Priority:  major        |   Milestone:  ongoing
 Version:               |  Resolution:  fixed
Keywords:  admin        |
------------------------+----------------------
Changes (by dustin):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 I've added this text to the site.html:

 {{{
   <!--! bug #1756 - annotate the registration form with better email
 instructions -->
   <p py:match="div[@id='content' and
 @class='register']/form/fieldset[1]/div[4]/p" py:attrs="select('@*')">
 <b style='color: red'>IMPORTANT:</b> Because of severe spam problems, this
 site        requires a validated email address before you can create a new
 ticket.  Trac
         will send you a verification token, which you will need to enter
 on the site.
         I'm sorry for the inconvenience, but please know that (non-spam)
 tickets are
         taken very seriously and are an important part of making Buildbot
 better.
   </p>

   <!--! bug #1756 - annotate /newticket when it displays an error,
 indicating
         that the user's email must be validated, and add a note about
 Captcha above
         the 'Create Ticket' button -->
   <p py:match="div[@id='content' and @class='error']/p[@class='message']"
 py:attrs="select('@*')">
     ${select('*|text()')}
     <py:if test="req.environ['PATH_INFO'] == '/newticket' and (not
 'preview' in req.args)">
       <br/><b>HINT:</b> have you verified your email address?  You cannot
 create tickets until you have done so.
     </py:if>
   </p>
   <div py:match="div[@id='content' and
 @class='ticket']//div[@class='buttons']" py:attrs="select('@*')">
     ${select('*|text()')} <br/>
     <span style='font-size: 75%'>(note that you may be required to
 complete a CAPTCHA if you have submitted several tickets)</span>
   </div>
 }}}

 So the registration form has a fairly long note on it; the /newticket
 error page has a "HINT"; and the successful /newticket page mentions that
 a CAPTCHA may be required.

 Now that I know how to do this, I should be able to make other tweaks as
 requested.  My XPath isn't so hot, so suggestions are welcome.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1756#comment:3>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation