[Buildbot-commits] [Buildbot] #1757: buildbot reconfig fails with exception

[Buildbot]

#1757: buildbot reconfig fails with exception
----------------------+-----------------------
Reporter:  sjl        |      Owner:
    Type:  undecided  |     Status:  new
Priority:  major      |  Milestone:  undecided
 Version:  0.8.3      |   Keywords:
----------------------+-----------------------
 The following error occurs when reconfiguring buildmaster:

 {{{
 2011-01-06 20:19:40+0200 [-] configuration update started
 2011-01-06 20:19:40+0200 [-] Unhandled Error
         Traceback (most recent call last):
           File "/home/buildmaster/buildbot/lib/python2.6/site-
 packages/buildbot-0.8.3-py2.6.egg/buildbot/master.py", line 703, in
 loadTheConfigFile
             d = self.loadConfig(f)
           File "/home/buildmaster/buildbot/lib/python2.6/site-
 packages/buildbot-0.8.3-py2.6.egg/buildbot/master.py", line 1032, in
 loadConfig
             d.addCallback(lambda res: self.loadConfig_Builders(builders))
           File "/home/buildmaster/buildbot/lib/python2.6/site-
 packages/Twisted-10.2.0-py2.6-linux-x86_64.egg/twisted/internet/defer.py",
 line 297, in addCallback
             callbackKeywords=kw)
           File "/home/buildmaster/buildbot/lib/python2.6/site-
 packages/Twisted-10.2.0-py2.6-linux-x86_64.egg/twisted/internet/defer.py",
 line 286, in addCallbacks
             self._runCallbacks()
         --- <exception caught here> ---
           File "/home/buildmaster/buildbot/lib/python2.6/site-
 packages/Twisted-10.2.0-py2.6-linux-x86_64.egg/twisted/internet/defer.py",
 line 542, in _runCallbacks
             current.result = callback(current.result, *args, **kw)
           File "/home/buildmaster/buildbot/lib/python2.6/site-
 packages/buildbot-0.8.3-py2.6.egg/buildbot/master.py", line 1032, in
 <lambda>
             d.addCallback(lambda res: self.loadConfig_Builders(builders))
           File "/home/buildmaster/buildbot/lib/python2.6/site-
 packages/buildbot-0.8.3-py2.6.egg/buildbot/master.py", line 1186, in
 loadConfig_Builders
             elif old.compareToSetup(data):
           File "/home/buildmaster/buildbot/lib/python2.6/site-
 packages/buildbot-0.8.3-py2.6.egg/buildbot/process/builder.py", line 475,
 in compareToSetup
             if setup['category'] != self.category:
         exceptions.KeyError: 'category'

 }}}

 This is probably due to the following code in buildbot/process/builder.py,
 compareToSetup() function:

 {{{
         if setup['buildHorizon'] != self.buildHorizon:
             diffs.append('buildHorizon changed from %s to %s' %
 (self.buildHorizon, setup['buildHorizon']))
         if setup['logHorizon'] != self.logHorizon:
             diffs.append('logHorizon changed from %s to %s' %
 (self.logHorizon, setup['logHorizon']))
         if setup['eventHorizon'] != self.eventHorizon:
             diffs.append('eventHorizon changed from %s to %s' %
 (self.eventHorizon, setup['eventHorizon']))
         if setup['category'] != self.category:
             diffs.append('category changed from %r to %r' %
 (self.category, setup['category']))
 }}}

 the dictionary lookups should probably be changed from {{{setup['foo']}}}
 to {{{setup.get('foo')}}}.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1757>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation