[Buildbot-commits] [Buildbot] #1797: remove keepStdinOpen from runprocess.py

Buildbot nobody at buildbot.net
Sun Feb 6 23:59:41 UTC 2011

#1797: remove keepStdinOpen from runprocess.py
Reporter:  dustin       |       Owner:  dustin
    Type:  enhancement  |      Status:  closed
Priority:  major        |   Milestone:  0.8.4
 Version:  0.8.3p1      |  Resolution:  fixed
Keywords:  kill         |
Changes (by Dustin J. Mitchell):

 * status:  new => closed
 * resolution:   => fixed


 Remove unused keepStdinOpen option

 This option is never passed from the master, and has defaulted to False
 (meaning that stdin gets closed).  Upon investigation of Twisted, the
 pp.closeStdin method only has an effect when usePTY=True:


 So with this patch, stdin is always closed, potentially after writing
 the required input.  Tests verify this.

 Fixes #1797
  Changeset: a8a5c8ba4d98a8aba186a615109ba6b91ee3558b

Ticket URL: <http://trac.buildbot.net/ticket/1797#comment:3>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

More information about the Commits mailing list