[Buildbot-commits] [Buildbot] #1797: remove keepStdinOpen from runprocess.py (was: default keepStdinOpen=True when usePTY=True)

[Buildbot]

#1797: remove keepStdinOpen from runprocess.py
------------------------+---------------------
Reporter:  dustin       |       Owner:  dustin
    Type:  enhancement  |      Status:  new
Priority:  major        |   Milestone:  0.8.4
 Version:  0.8.3p1      |  Resolution:
Keywords:  kill         |
------------------------+---------------------

Comment (by dustin):

 It turns out that
  * with usePTY=True, keepStdinOpen is ignored:
 http://twistedmatrix.com/trac/browser/tags/releases/twisted-10.2.0/twisted/internet/process.py#L930
  * with usePTY=False, there's never a good reason to leave stdin open - at
 least, the opportunity to do so is never used by the master or any of the
 slave-side commands.

 So I'm morphing this bug to just removing support for it.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/1797#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation