[Buildbot-commits] [Buildbot] #97: Use svn switch to improve efficiency

[Buildbot]

#97: Use svn switch to improve efficiency
------------------------+------------------------
Reporter:  retracile    |       Owner:
    Type:  enhancement  |      Status:  reopened
Priority:  major        |   Milestone:  undecided
 Version:  0.7.5        |  Resolution:
Keywords:               |
------------------------+------------------------

Comment (by dustin):

 Replying to [comment:4 duncanphilipnorman]:
 >  1. After a quick glance, it looks like `svn switch` could be used to
 implement an argument like `clobberOnBranchChange=False`.  This would
 apply to `mode=incremental` as well as many of the methods in `mode=full`.

 I'd rather that be "switch_branches" or something like that.  You're right
 that it applies to both modes, and multiple behaviors.

 >  1. I found a `Source` in `steps/source/oldsource.py`... is that the one
 that the master-side `SVN` inherits from?

 Yes.

 >  1. `SVN._sourcedirIsUpdatable` checks whether the `.svn` exists, but it
 doesn't check if the branch has changed.  I can't find this check
 elsewhere (even in the `Source` class).  Where is that logic?

 That may be missing in the master-side step.  In the slave-side steps,
 that's stored in sourcedata, which is mostly handled in the base class
 (see writeSourcedata and readSourcedata).

 >  1. In 0.8.3, if an `update` operation failed, there was a fallback to
 do clobber and full checkout.  I don't see that in the 0.8.5
 documentation... and I also don't see it in the current source.  What am I
 missing?

 Hm, I don't see that either.  I could have sworn that got implemented, but
 perhaps that, too, is missing in the master-side commands.

-- 
Ticket URL: <http://trac.buildbot.net/ticket/97#comment:5>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation