[Buildbot-commits] [Buildbot] #97: Use svn switch to improve efficiency

[Buildbot]

#97: Use svn switch to improve efficiency
------------------------+------------------------
Reporter:  retracile    |       Owner:
    Type:  enhancement  |      Status:  reopened
Priority:  major        |   Milestone:  undecided
 Version:  0.7.5        |  Resolution:
Keywords:               |
------------------------+------------------------

Comment (by duncanphilipnorman):

 Replying to [comment:3 dustin]:
 > Reopening is fine.  However, this should be implemented in the new
 master-side step, rather than in the slave-side step.  On the master-side
 step, this should probably be a new method for the svn step.

 Ah, I see that the code has been refactored since the 0.8.3.  A few
 things.
  1. After a quick glance, it looks like `svn switch` could be used to
 implement an argument like `clobberOnBranchChange=False`.  This would
 apply to `mode=incremental` as well as many of the methods in `mode=full`.
  1. I found a `Source` in `steps/source/oldsource.py`... is that the one
 that the master-side `SVN` inherits from?
  1. `SVN._sourcedirIsUpdatable` checks whether the `.svn` exists, but it
 doesn't check if the branch has changed.  I can't find this check
 elsewhere (even in the `Source` class).  Where is that logic?
  1. In 0.8.3, if an `update` operation failed, there was a fallback to do
 clobber and full checkout.  I don't see that in the 0.8.5 documentation...
 and I also don't see it in the current source.  What am I missing?

-- 
Ticket URL: <http://trac.buildbot.net/ticket/97#comment:4>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation