[Buildbot-commits] [SPAM] Re: [Buildbot] #820: Change imports fail on 8-bit comments

[Buildbot]

#820: Change imports fail on 8-bit comments
-------------------+--------------------------------------------------------
Reporter:  dustin  |       Owner:       
    Type:  defect  |      Status:  new  
Priority:  major   |   Milestone:  0.8.0
 Version:  0.8.0   |    Keywords:       
-------------------+--------------------------------------------------------

Comment(by dustin):

 Catlee has a decent patch:
 http://github.com/catlee/buildbot/commit/4a4cd0b70739dcd88a6f221fac20e093f1842059
 which has a few small tweaks required: the tests should call
 {{{upgrade(quiet=True)}}}, and remove_none should return {{{u""}}} instead
 of {{{""}}} on None.

 This implements what I'll call option 1: assume an encoding, and use
 "replace" to ignore any errors in the encoding.  This will get folks
 upgraded to 0.8.0 with minimal fuss (usability) but at a cost in
 correctness.

 Option 2 is to remove the "replace" argument, and maybe catch the
 UnicodeEncodeError and display a nice friendly error message when the
 encodings don't match.  Then write a
 {{{contrib/fix_changes_pickle_encoding.py}}} script that takes an encoding
 as an argument and applies it to the entire changes pickle (making a
 backup first of course).

 Option 3 is option 2 with the addition of a {{{--relax}}} flag to
 'buildbot upgrade-master' that would automatically add the "replace"
 option in.  Folks who don't really care about encodings could use this.

 I prefer option 2.  Opinions?

 Thebrasse: you're right, and that needs a new, separate bug.

-- 
Ticket URL: <http://buildbot.net/trac/ticket/820#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation