[Buildbot-commits] [SPAM] Re: [Buildbot] #820: Change imports fail on 8-bit comments

[Buildbot]

#820: Change imports fail on 8-bit comments
-------------------+--------------------------------------------------------
Reporter:  dustin  |       Owner:       
    Type:  defect  |      Status:  new  
Priority:  major   |   Milestone:  0.8.0
 Version:  0.8.0   |    Keywords:       
-------------------+--------------------------------------------------------
Changes (by thebrasse):

 * cc: thebrasse@… (added)


Comment:

 I'm pretty sure that I ran into a similar problem in 0.8.0beta1.

 git_builbot.py was sending plain strings to the master containing non-
 ascii characters. The fix in that case was to make git_buildbot.py send
 unicode strings instead.

 It seems that _addChangeToDatabase() should also convert the plain strings
 to unicode strings before sending them to the database. A problem in this
 case is that we don't know what encoding the plain strings have. Perhaps
 it's OK the tell {{{buildbot upgrade-master}}} what encoding to assume for
 the plain strings it needs to convert to unicode?

-- 
Ticket URL: <http://buildbot.net/trac/ticket/820#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation