[Buildbot] #2872: No error is reported when suppressionFile does not exist

[Buildbot trac]

#2872: No error is reported when suppressionFile does not exist
---------------------+-----------------------
Reporter:  wentasah  |       Owner:  MikeLing
    Type:  defect    |      Status:  assigned
Priority:  minor     |   Milestone:  0.8.x
 Version:            |  Resolution:
Keywords:  simple    |
---------------------+-----------------------

Comment (by MikeLing):

 Replying to [comment:8 dustin]:
 > Let's try to solve that first, by updating the unit test under
 `slave/buildslave/test` to correctly show the problem, and then applying
 your fix to show that it actually solves the problem.

 Yeah, but after read those tests in there, I found we already have the
 test with doesn't exist
 file(https://github.com/buildbot/buildbot/blob/master/slave/buildslave/test/unit/test_commands_transfer.py#L176).

 And after a second thought about it, I suddenly notice the
 'open'(https://github.com/buildbot/buildbot/blob/1147bf7a0ebe472a63ad5f7eef473648bb805a14/slave/buildslave/commands/transfer.py#L91)
 itself should return 'No such file or directory:' error with an unexist
 file path, and it should been catch as an 'Exception' I think. Therefore,
 my fix in transfer.py is redundant code for it. :)

 So I'm wondering if we still need work on this issue? Maybe it had been
 fixed accidently? ;)

 Please tell me if I misunderstand something or went into wrong direction,
 thank you!

--
Ticket URL: <http://trac.buildbot.net/ticket/2872#comment:9>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation