[Buildbot] #2872: No error is reported when suppressionFile does not exist

[Buildbot trac]

#2872: No error is reported when suppressionFile does not exist
---------------------+-----------------------
Reporter:  wentasah  |       Owner:  MikeLing
    Type:  defect    |      Status:  assigned
Priority:  minor     |   Milestone:  0.8.x
 Version:            |  Resolution:
Keywords:  simple    |
---------------------+-----------------------

Comment (by dustin):

 In your attachment, you've written the first few lines of a test for this
 issue.  And your fix in transfer.py looks good, too.  It appears you've
 found the root of the bug, which is that `SlaveFileUploadCommand` does not
 correctly return an error when the file does not exist.

 Let's try to solve that first, by updating the unit test under
 `slave/buildslave/test` to correctly show the problem, and then applying
 your fix to show that it actually solves the problem.

 Buildbot's unit tests only run master code or slave code, not both -- so
 if this is the only problem (and I suspect it is), then you can only test
 it in the slave tests.

--
Ticket URL: <http://trac.buildbot.net/ticket/2872#comment:8>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation