[Buildbot] #3258: 0.8.x: Returning SKIPPED from new-style step results in finish being invoked twice
Buildbot trac
trac at buildbot.net
Mon May 18 05:16:02 UTC 2015
#3258: 0.8.x: Returning SKIPPED from new-style step results in finish being
invoked twice
----------------------+------------------------
Reporter: vlovich | Owner:
Type: undecided | Status: new
Priority: major | Milestone: undecided
Version: 0.8.10 | Resolution:
Keywords: |
----------------------+------------------------
Comment (by vlovich):
The code-flow is as follows:
{{{
doStep & isNew.
result = yield self.run()
old_finished(result)
doStep = False because result == SKIPPED
eventually(self._finishFinished, SKIPPED) to workaround fix #837
}}}
One fix that seems to work is that old_finished should only be called if
result != SKIPPED.
--
Ticket URL: <http://trac.buildbot.net/ticket/3258#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation
More information about the bugs
mailing list