[Buildbot] #3180: Fix call to subprocess.Popen in git_buildbot.py

[Buildbot trac]

#3180: Fix call to subprocess.Popen in git_buildbot.py
------------------------+--------------------
Reporter:  verm         |       Owner:
    Type:  defect       |      Status:  new
Priority:  minor        |   Milestone:  0.9.+
 Version:  master       |  Resolution:
Keywords:  git, simple  |
------------------------+--------------------

Comment (by verm):

 Replying to [comment:1 dustin]:
 > I don't think it *must* be a list --
 https://docs.python.org/2/library/subprocess.html#subprocess.Popen

 It doesn't need to be a list if it's a single command with no args eg `ls`
 but you need to do `['ls', '-l']` for args otherwise it runs `"ls -l"` and
 you get a no such file or directory error.

 > Perhaps we could just set shell=True?

 Not sure what the ramifications of this are if none it makes sense.


 > Some tests would be great, too.

 I will see about that and a patch.


 > I'm setting this to minor since it's a contrib script the functionality
 for which is also available in Buildbot proper.

 OK.

--
Ticket URL: <http://trac.buildbot.net/ticket/3180#comment:2>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation