[Buildbot] #3180: Fix call to subprocess.Popen in git_buildbot.py

[Buildbot trac]

#3180: Fix call to subprocess.Popen in git_buildbot.py
------------------------+--------------------
Reporter:  verm         |       Owner:
    Type:  defect       |      Status:  new
Priority:  minor        |   Milestone:  0.9.+
 Version:  master       |  Resolution:
Keywords:  git, simple  |
------------------------+--------------------
Changes (by dustin):

 * keywords:  git => git, simple
 * priority:  major => minor
 * milestone:  undecided => 0.9.+


Comment:

 I don't think it *must* be a list --
 https://docs.python.org/2/library/subprocess.html#subprocess.Popen

 Perhaps we could just set shell=True?

 Some tests would be great, too.

 I'm setting this to minor since it's a contrib script the functionality
 for which is also available in Buildbot proper.

--
Ticket URL: <http://trac.buildbot.net/ticket/3180#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation