[Buildbot] #2818: [nine] rewrite buildsteps to not write to status

Buildbot trac trac at buildbot.net
Tue Sep 2 01:52:18 UTC 2014

#2818: [nine] rewrite buildsteps to not write to status
Reporter:  dustin       |       Owner:  dustin
    Type:  enhancement  |      Status:  new
Priority:  major        |   Milestone:  0.9.0
 Version:  0.8.7p1      |  Resolution:
Keywords:               |

Comment (by dustin):

 I've been stalled on this for three months :(

 This bug includes:

  * making waitingForLocks a local (private) attribute of !BuildStep (why
 was this ever on the status?!)
  * building a fake `self.step_status` for old-style steps with methods
    * `setText`
    * `setText2`
  * removing uses of `self.step_status` in
 `master/buildbot/process/buildstep.py` - in most cases these are already
 paired with a data API call, so they can simply be removed.  Calls to
 `setText` can be replaced with calls to `updateSummary`.
  * removing progress/ETA support (I think there's already a bug to re-add
 this in a more functional fashion)
  * removing `setSkipped` calls (nothing ever calls `isSkipped` anyway)
  * adding data API support for hidden steps
  * fudge things in !LoggingBuildStep so that they continue to work as much
 as possible, even though the `step_status` argument to `evaluateCommand`
 probably doesn't do what the user expects anymore
  * update tests
    * for changes above
    * the default expected final status for every step has changed from
 `status_text=['generic']`, and will need to be updated in each test.  It's
 probably best to make this argument optional, since it's not particularly
 interesting in most cases.

 Much of this has been done in
 https://github.com/djmitche/buildbot/tree/bug2818 -- mostly missing the
 updated tests.

Ticket URL: <http://trac.buildbot.net/ticket/2818#comment:1>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation

More information about the bugs mailing list