[Buildbot] #2547: Can't have slaves and builders with the same name

[Buildbot trac]

#2547: Can't have slaves and builders with the same name
-----------------------------+--------------------
Reporter:  dustin            |       Owner:
    Type:  enhancement       |      Status:  new
Priority:  patches-accepted  |   Milestone:  0.9.+
 Version:  0.8.7p1           |  Resolution:
Keywords:  simple            |
-----------------------------+--------------------

Comment (by ksandarusi):

 Thanks for the response![[BR]]
 [[BR]]


 There is one other thing worth mentioning. When I attempted to recreate
 the issue, it didn't pose a problem at first. You can actually create
 slaves with the same name as builders in your config.[[BR]]
 [[BR]]
 The reason being that the BuildSlave class actually doesn't set the .name
 variable of itself, it only sets the .slavename. Therefore, you CAN have a
 c['slaves'] element with the same 'name' (because its actually slavename)
 as an element in c['builders']. I believe I verified this by actually
 editing the BuildSlave init function to include 'self.name = name'; after
 trying to run with the following edit, the runtime exception occurred like
 expected.[[BR]]
 [[BR]]
 I think it is a small hole worth patching up, but overall it should be
 fine.

--
Ticket URL: <http://trac.buildbot.net/ticket/2547#comment:5>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation