[Buildbot] #2547: Can't have slaves and builders with the same name

[Buildbot trac]

#2547: Can't have slaves and builders with the same name
-----------------------------+--------------------
Reporter:  dustin            |       Owner:
    Type:  enhancement       |      Status:  new
Priority:  patches-accepted  |   Milestone:  0.9.+
 Version:  0.8.7p1           |  Resolution:
Keywords:  simple            |
-----------------------------+--------------------

Comment (by dustin):

 Sorry to have left you hanging there!

 I think you've got a good understanding of the problem.  It sounds like
 the solution you're envisioning is to add two `MultiService` instances to
 Botmaster as child services, and have Botmaster continue to manage their
 contents (during reconfigs, etc.)

 That makes great sense, and is a nice, simple solution.  The only
 objection I have -- and it's not a strong one -- is that it's not very
 good separation of concerns.  It leaves Botmaster doing the work of three
 different objects -- the list of builders, the list of buildslaves, and
 the coordination between them.  From a design perspective it'd be nicer to
 have three classes, each taking doing one job.

 The `BuildSlaveManager` suggestion was part of the now-largely-abandoned
 work on implementing a new master/slave communication protocol.  So there
 is no such class right now.  The idea, though, was that it would do the
 "list of buildslaves" job mentioned in the previous paragraph.

 So I'll leave it up to you which way to make the design choice.  I find
 such choices often become clear once you start coding, especially when
 writing tests.

--
Ticket URL: <http://trac.buildbot.net/ticket/2547#comment:4>
Buildbot <http://buildbot.net/>
Buildbot: build/test automation