[users at bb.net] Scheduler owner property

[Yngve N. Pettersen]

Hi,

Thanks.

I'll get it when I update to the next version, then

On Wed, 13 Mar 2019 12:56:41 +0100, Pierre Tardy <tardyp at gmail.com> wrote:

> So your use case is the builder page.
> the builder page is indeed displaying the owner property, and it would
> indeed make sense that it worked better.
>
> 'owners' property is built from multiple source and is the correct one to
> use
> https://github.com/buildbot/buildbot/blob/8efebda8d217ff88d578c8b3c0d597a276490baa/master/buildbot/process/build.py#L463
>
> I fixed the builder page for that:
> https://github.com/buildbot/buildbot/pull/4657
>
> Pierre
>
> On Wed, Mar 13, 2019 at 12:26 PM Yngve N. Pettersen <yngve at vivaldi.com>
> wrote:
>
>> Hi,
>>
>> The place I am trying to add this is in the call to the
>> SingleBranchScheduler constructor (or other similar classes) when  
>> setting
>> up the schedulers in the master.cfg file.
>>
>> The "owner" property is the one mentioned in
>> <
>> http://docs.buildbot.net/current/manual/configuration/schedulers.html#id11>,
>>
>> and it is also AFAICT the one used in /#/builders/1 and similar  
>> locations.
>>
>> It would not have been any problem if that page (and similar locations)
>> had used both owner and owners.
>>
>> On Wed, 13 Mar 2019 11:41:22 +0100, Pierre Tardy <tardyp at gmail.com>  
>> wrote:
>>
>> > Hi,
>> >
>> > It depends in which context you want to get this information.
>> > The information might be in several places. (owner from change? owner
>> > from
>> > force builder, etc)
>> > There is also indeed the 'owner' property, which was later switch to
>> > owners
>> > so that there can be several owners.
>> > It is indeed a bit messy, as we try to keep backward compatibility.
>> >
>> > So we have a utility function which gather all sources of information.
>> >
>> https://github.com/buildbot/buildbot/blob/8efebda8d217ff88d578c8b3c0d597a276490baa/master/buildbot/reporters/utils.py#L158
>> >
>> > Regards
>> > Pierre
>> >
>> > On Wed, Mar 13, 2019 at 2:05 AM Yngve N. Pettersen <yngve at vivaldi.com>
>> > wrote:
>> >
>> >> Hi,
>> >>
>> >> One of the comments I have received from my colleagues (including the
>> >> CEO)
>> >> about our new build system is that the information about the builds  
>> is
>> >> missing information about who committed the changes being built.
>> >>
>> >> This information is available in the "owners" build property, but  
>> NOT in
>> >> the "owner" build property, which is specified by the scheduler.
>> >>
>> >> The only example in the documentation shows the owner email addresses
>> >> added as a list. Unfortunately, there is no example for how to add  
>> that
>> >> information from the changes that triggered the scheduler (for
>> >> reference:
>> >> util.Property does not work, "not JSONable").
>> >>
>> >> So, how do I get that property added for each scheduled build?
>> >>
>> >> --
>> >> Sincerely,
>> >> Yngve N. Pettersen
>> >> Vivaldi Technologies AS
>> >> _______________________________________________
>> >> users mailing list
>> >> users at buildbot.net
>> >> https://lists.buildbot.net/mailman/listinfo/users
>> >>
>> > --
>>
>>
>> --
>> Sincerely,
>> Yngve N. Pettersen
>> Vivaldi Technologies AS
>>
> --


-- 
Sincerely,
Yngve N. Pettersen
Vivaldi Technologies AS