[users at bb.net] build step VS2017

[Steve Hoelzer]

On Thu, Sep 6, 2018 at 9:02 AM Riccardo Corsi
<riccardo.corsi at kairos3d.it> wrote:
>
> Hi all,
>
> while trying to setup a build for Visual Studio 2017 I get this message:
>
> My guess is that VS2017 is correctly initialized (here), but not listed in the master setup script
> https://github.com/buildbot/buildbot/blob/2ff978afab86a170a5240d7247b81d03348a03e1/master/setup.py#L322

Yes, I think you're right. I also noticed that VC141 is not in the
master setup script.

But even if they were, the path in vstudio.py is hardcoded for VS 2017
Community Edition. It will not work for Professional or Enterprise
Editions. For some reason VS 2017 uses different paths for each
edition which is a change from earlier VS versions.

It looks like someone has solved this for MsBuild141 in vstudio.py
(also not in the master setup script). The start method uses
vswhere.exe [1] to find the VS 2017 path. That seems like Microsoft's
recommended approach. I think VS2017 and VC141 need an update to do
the same kind of thing.

Steve