[users at bb.net] Accessing properties within an extract_fn

[Pierre Tardy]

Le mer. 4 janv. 2017 à 07:36, Elliot Saba <staticfloat at gmail.com> a écrit :

> Thanks Pierre.  I would have used setProperty, but I find it rather opaque
> which parameters can have a function passed instead of a value, and which
> cannot, and furthermore if that function would be passed the set of
> properties or not.
>
Hi Elliot,
You can assume that any step's argument taking a standard type parameter
(string, int, etc) can also be passed a renderable, which can itself be a
function, if decorated with @util.renderer.
If this does not work, then it is a mistake and should be reported.

I am not sure here if you are talking about the "steps.SetProperty" that
tomprince pointed out in my PR, or if you are talking about the
props.setProperty of your renderer.


> I suggest you use the actual working version of the python function
> <https://github.com/staticfloat/julia-buildbot/blob/0bfe31a611004c794eb0e5c673309d5476f682c4/master/package.py#L45-L77>,
> it took me a little while to figure out how to finagle the data to flow
> properly, and I wouldn't want to lead anyone astray.
>
I did not realize how complicated it is to use string.format with a
properties object.
But your implementation looks good, apart it does a useless /bin/true shell
command on the worker
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.buildbot.net/pipermail/users/attachments/20170104/62aec68f/attachment.html>