[users at bb.net] Need a Python 3 enabled builder for buildbot.test

Craig Rodrigues rodrigc at crodrigues.org
Sun Feb 5 05:52:49 UTC 2017


On Fri, Feb 3, 2017 at 2:32 AM, Pierre Tardy <tardyp at gmail.com> wrote:

> Hi Craig,
> So it is not realistic to ask people to try python3 as well unless we have
> a clear PASS/FAIL status of whether there is a regression or not.
>
>
I previously asked you specifically on IRC if you could change your
workflow so that:

(1)  create two virtualenvs, one for Python 2.7, and one for Python 3.x
(2)  as you are working on a patch, you work in a single workspace, but you
test your patch
      in the two separate virtualenvs, maybe in separate windows

This is additional work, and probably a change for how you are used to
working,
but it helps reduce the potential for Python 3 regressions.
This is the way I have been working, so as to fix things on Python 3, but
not to introduce Python 2 regressions.

It is important for you to be on board for working in this way,
because you are doing the majority of code reviews, branch merges, and new
code development for buildbot.

It's obvious that you are not changing your workflow as I previously asked.
That's your choice, and I cannot force you to do what you don't want to do,
but that is still annoying for me to see.

In addition to breaking
For example, in addition to breaking test_util_httpclientservice.py (which
I fixed on Python 3 on Jan. 28,
and then submitted a patch to fix what you broke)
you have introduced new code via
https://github.com/buildbot/buildbot/pull/2722 in the past 24 hours
which doesn't work on Python 3, so this is introducing new failures.

Am I asking too much of you to work with two virtualenvs and not
break things on Python 3, and introduce new code which doesn't work on
Python 3?

--
Craig
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.buildbot.net/pipermail/users/attachments/20170204/3a770835/attachment.html>


More information about the users mailing list