[users at bb.net] change in _dumbwin32proc.py

[Adam Wozniak]

I’ll feed this back to twisted as a bug.

--Adam

From: Pierre Tardy [mailto:tardyp at gmail.com]
Sent: Wednesday, April 19, 2017 8:55 AM
To: Adam Wozniak <adam.wozniak at axonvr.com>; users at buildbot.net
Subject: Re: [users at bb.net] change in _dumbwin32proc.py

Hi Adam,
I guess this problem is more in the twisted framework. It would be wise to rather submit or look for similar bug in their own tracker:
http://twistedmatrix.com/trac/

As you are on windows 10, did you try to run Buildbot in a linux bash shell<https://www.howtogeek.com/249966/how-to-install-and-use-the-linux-bash-shell-on-windows-10/>?

Frankly there are quite few windows users, inside the buildbot and twisted community, and it is quite hard to claim a strong windows support without them. Its a bit of a chicken and the egg problem, as we have few windows, users, we have even less windows contributions.
Perhaps linux bash shell is the solution for us to better support windows.

Regards,
Pierre

On Tue, Apr 18, 2017 at 5:32 PM Adam Wozniak <adam.wozniak at axonvr.com<mailto:adam.wozniak at axonvr.com>> wrote:
To make git polling work for me, I had to make the change below.

Based on zturner comment #17 in
http://trac.buildbot.net/ticket/2936

Win 10 Pro, Version 1703, OS Build 15063.138, 64 bit
Python 2.7
Buildbot version: 0.9.5
Twisted version: 17.1.0


$ diff -uprN _dumbwin32proc.py.orig _dumbwin32proc.py
--- _dumbwin32proc.py.orig      2017-04-18 08:25:31.639822200 -0700
+++ _dumbwin32proc.py   2017-04-18 08:25:43.310989300 -0700
@@ -210,7 +210,7 @@ class Process(_pollingfile._PollingTimer
         # TODO: error detection here.  See #2787 and #4184.
         def doCreate():
             self.hProcess, self.hThread, self.pid, dwTid = win32process.CreateProcess(
-                command, cmdline, None, None, 1, 0, env, path, StartupInfo)
+                None, cmdline, None, None, 1, 0, env, path, StartupInfo)
         try:
             try:
                 doCreate()


_______________________________________________
users mailing list
users at buildbot.net<mailto:users at buildbot.net>
https://lists.buildbot.net/mailman/listinfo/users
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.buildbot.net/pipermail/users/attachments/20170419/3359c640/attachment.html>