[users at bb.net] [Foreign Sender] Re: Detailed log of RemoveDirectory step's failure?

[Benoît Allard]

On Wed, 06 Jul 2016 19:06:53 +0000
Tom Prince <tom.prince at hocat.ca> wrote:

> On Tue, Jun 28, 2016 at 3:10 PM Vasily <just.one.man at yandex.ru> wrote:
> 
> > I think I can try to dig a monkey patch for shutil.rmtree that uses
> > Unicode version of Win32 API which, when supplied with specially
> > crafted path, can delete long names.
> >
> > Is it interesting for the community?
> >
>  It would definitely be worthwhile to improve the handling of
> recursive deletes on windows. Just a couple of notes:
> 
> 1) The code doesn't actually use shutil.rmtree on windows now.
> 2) I don't think it is reasonable to ask users to specially craft
> paths to use this (I'm not entirely sure what you mean by that
> though).

I had made a pull-request long time ago [0] to just get rid of that
tangled code, and replace it with the windows equivalent of
``system.call(['rm', '-r', directory])`` (what we actually do on posix
systems), which at that time was what worked for me best. If I remember
correctly, I had issues on some specific operating systems where the
subdirectories were to slow to be deleted, so that when trying to
delete the parent directory, there was still entries beneath it.

That PR stalled as I lost interest in windows slaves.

Just to say, that code has been broken for at least 4 years now.

Regards,
Ben.

[0] https://github.com/buildbot/buildbot/pull/540
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.buildbot.net/pipermail/users/attachments/20160708/a4409677/attachment.bin>