[users at bb.net] 0.9.0rc2 and collapseRequests

[Neil Gilmore]

Whoops! By 'both' I mean both builders that were brought to my attention.

Neil Gilmore
grammatech.com

On 8/31/2016 11:40 AM, Neil Gilmore wrote:
> Hi everyone,
>
> I was previously directed to set collapseRequests to true globally in 
> our master.cfg. Using a previous version, we had been merging 
> requests, but only for certain builders. It doesn't appear to be 
> working, though it's hard to tell because both workers/builders seem 
> to be completely stalled at the moment. There's queued builds, but 
> nothing executing.
>
> Looking through the code I see that in BuildRequest.canBeCollapsed(), 
> down around line 272 in buildrequest.py, it appears that build 
> requests with differing revisions will not be collapsed.
>
> However, the comments for the class BuildRequestCollapser (line 37 of 
> the same file) seem to indicate that revision is not to be included in 
> the consideration of whether to collapse a request.
>
> The code and comments seem to conflict with each other.
>
> For our purposes, we definitely want collapsing to happen, and want 
> the buildrequest with the most recent revision to be the one built. I 
> can certainly hack up the code to do what I want, but I thought I 
> should address this here, too.
>
> Thanks again for your time.
>
> Neil Gilmore
> grammatech.com
> _______________________________________________
> users mailing list
> users at buildbot.net
> https://lists.buildbot.net/mailman/listinfo/users