[users at bb.net] buildbot-0.9.0rc1, createSummary, and SyncLogFileWrapper troubles.

[Neil Gilmore]

Hi everyone,

We've been trying to move from primarily 0.8.6p1(?) to 0.9.0rc1. We're 
having some problems.

Among them is a custom build step that no longer works. It looks 
substantially like this:

class MyCustomStep(ShellCommand):
     name = "errorlog"
     haltOnFailure = 1
     description = ["checking for errors"]
     descriptionDone = ["done checking for errors"]

     OFFprogressMetrics = ('output',)
     # things to track: number of files compiled, number of directories
     # traversed (assuming 'make' is being used)

     def createSummary(self, cmd):
         self.addCompleteLog('stdio_head',cmd.getText()[0:65536])

We use this step to create a shorter log that we can use in emails 
without choking our systems.

cmd.getText() never returns any text.

cmd is a SyncLogFileWrapper, and I've tried writing nearly everything in 
it to twistd.log via log.msg. It never seems to have any 
finishDeferreds, or chunks, and always gets marked finished.

I thought that maybe I needed to call waitUntilFinished(). 
Unfortunately, this function excepts in code from the 0.9.0rc1 tarball, 
and the error is in both the github master and 0.9.0 branch 
(finishDeferreds is spelled finishDefereds). Fixing it didn't help, as 
there were no finishDefeereds out there to finish anyway.

That, combined with the fact that the only place where the log argument 
to createSummary() is used is in the integration tests, leads me to 
think that this hasn't been tested too much, if at all.

I've thought about using the data API, but I'd need a log id. 
SyncLogFileWrapper doesn't seem to have one. I'm currently working on 
getting it from the step, because I can at least get the step id, and I 
hope I can work my way down from there.

I think I'd rather not try using a LogObserver, as I don't think we want 
to be accumulating large logs in memory.

Has anyone out there successfully gotten text from the log argument of 
CreateSummary in 0.9.0rc1?

Thank you for your time.

Neil Gilmore
grammatech.com