[devel at bb.net] RFC: Mercurial bookmark and multi-branch support

[Dustin J. Mitchell]

On Thu, Feb 28, 2019 at 7:41 PM Hollis Blanchard <
hollis_blanchard at mentor.com> wrote:

> I work with some Mercurial trees that use more than one bookmark (an
> alternative form of branches). I found that Buildbot only supports a single
> branch, so I had to extend it.
>
> Logically speaking I think there are three changes: using StateMixin,
> supporting multiple branches, and supporting bookmarks. Is it worth trying
> to to split them up?
>

It depends how much effort that entails, but typically changes are easier
to review if they do only one thing.  I'm not familiar enough with the code
to comment on the patch.


> The attached patch is an RFC because:
>
>    - I'm not sure how you like patches delivered (email?), or what style.
>
> Github PR's please :)

>
>    - It's against 1.8.0. I will update to master and retest everything
>    with python3 after I figure out how you'd like the new code to be submitted.
>    - I didn't attempt to do anything with backwards compatibility for old
>    databases that only track a single branch. Do you care? Maybe it's as easy
>    as checking the type of the getState() result, and ignoring/replacing it if
>    it's a single revision?
>
> Typically we are concerned with backward compatibility, so yes, some work
on that would be good.

Dustin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.buildbot.net/pipermail/devel/attachments/20190301/99ee0f1c/attachment.html>