[devel at bb.net] Need a Python 3 enabled builder for buildbot.test

Craig Rodrigues rodrigc at crodrigues.org
Sun Feb 19 23:12:38 UTC 2017


On Sun, Feb 5, 2017 at 1:51 AM, Pierre Tardy <tardyp at gmail.com> wrote:

>
>
> Le dim. 5 févr. 2017 à 06:52, Craig Rodrigues <rodrigc at crodrigues.org> a
> écrit :
>
>>
>>
>> On Fri, Feb 3, 2017 at 2:32 AM, Pierre Tardy <tardyp at gmail.com> wrote:
>>
>> Hi Craig,
>>
>> So it is not realistic to ask people to try python3 as well unless we
>> have a clear PASS/FAIL status of whether there is a regression or not.
>>
>>
>> I previously asked you specifically on IRC if you could change your
>> workflow so that:
>>
>> (1)  create two virtualenvs, one for Python 2.7, and one for Python 3.x
>> (2)  as you are working on a patch, you work in a single workspace, but
>> you test your patch
>>       in the two separate virtualenvs, maybe in separate windows
>>
>
> Hi Craig,
> Indeed, I'd like to avoid changing my workflow for py3. I certainly plaid
> culprit for that, and I apologize for your frustration.
> I use cctrial <https://pypi.python.org/pypi/cctrial> to run the tests are
> impacted by my tests, and the upload so that the CI can handle the full
> matrix.
>
> py3 is not the only regression possibility. It is the same for the 24 code
> configurations that we support. For example I don't run manually the tests
> against mysql innodb.
> Sometimes mysql brokes (e.g https://github.com/buildbot/buildbot/pull/2715),
> but thanks to the CI we know about it before merge.
>
>


> I have already spent a big amount of time on py3 this week, much more than
> I expected, and now I am late on the release I planned to do this week.
> I would have liked there were some acknowledgement from you about that.
>
>
I acknowledge that you have been very good at reviewing and merging my  py3
changes,
and I thank you very much for that.
However, other than reviewing my changes, I haven't seen you actively work
on any py3 related code,
so I don't understand where the time you are spending on py3 is going,
unless you count
it all as review time.



> Now that we have CI on py3 I expect that there are no more regressions.
> Again I am not against you I try to figure out the correct amount of
> attention I need to put on this to stay productive
>


One of the reasons I have pushed heavily to get a working CI setup of py3
is mainly because of you.  You have demonstrated that you don't work in a
py3 environment at all,
and have even quite recently pushed changes to buildbot which break py3.

The biggest help you could provide is to have two virtualenvs (1 py2, and 1
py3) for
and have a single workspace with your code, and do more testing before
you even push things to GitHub.  Since you are the largest contributor to
buildbot,
you set the pace for how the project goes.

--
Craig
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.buildbot.net/pipermail/devel/attachments/20170219/d4553f11/attachment.html>


More information about the devel mailing list