[devel at bb.net] Review request for bug2340 branch ("slave"->"worker" renaming in master)

[Pierre Tardy]

>
> - [ ] To get raw diff via git:
>
> git clone https://github.com/buildbot/buildbot.git
> cd buildbot
> git fetch --all
> git diff origin/master...origin/bug2340
>

I'll go for that one. This reminds me the good old time when I reviewed the
nine branch from dustin, trying to understand what all this data api thing
was about.


git diff buildbot/master master/docs/manual/worker-transition.rst

+  ``workdir`` property source from ``"slave (deprecated)"`` to
+  ``"worker (deprecated)"``.
While we are at it, I would remove those deprecated properties. They have
been for a good while, and deserve a fair death.
+API changes between 0.9.0b7 and 0.9.0b8 (done without providing fallback).
+
+.. todo::
+
+   This whole section may be removed since it's not important for users
+   upgrading to 0.9.0.
+

Well, there as been already some people adopting nine before it was
released (at least people in my extended team), so I think it should be
good to keep it at least for a little time.

+     - ``/masters/n:masterid/workers/n:workersid``

its  workerid. I can verify that the code is okay, this is just a typo in
the doc.

 git diff buildbot/master master/buildbot/test/unit/test_config.py

+from buildbot.test.util.warnings import assertNotProducesWarnings
+from buildbot.test.util.warnings import assertProducesWarning
[...]
+        with assertProducesWarning(
[nit] I think it is more unittest idiomatic to say 'with
self.assertProducesWarning', means you would rather import something like:
from buildbot.test.util.warnings import warningAssertionMixins


diff --git a/master/buildbot/db/buildslave.py
b/master/buildbot/db/buildslave.py
new file mode 100644
index 0000000..4f486b1
--- /dev/null
+++ b/master/buildbot/db/buildslave.py
@@ -0,0 +1,30 @@
[...]
+deprecatedWorkerModuleAttribute(locals(), _WorkersConnectorComponent,
+
 compat_name="BuildslavesConnectorComponent",
+                                new_name="WorkersConnectorComponent")
diff --git a/master/buildbot/db/buildslaves.py
b/master/buildbot/db/buildslaves.py
deleted file mode 100644
index 8613f03..0000000
--- a/master/buildbot/db/buildslaves.py
+++ /dev/null

looks like db/buildslaves.py was renamed in the process of deprecation!


I think this whole thing is a great job! I join Dustin on the amazin' words.

As we know this beast is working (nine.bb.net), IMHO we should merge it and
treat the remaining todos in subsequent PR, which will be much much easier
to review.

Cheers
Pierre
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.buildbot.net/pipermail/devel/attachments/20160220/e3cc42f0/attachment.html>