[devel at bb.net] Use of module wrapping in bug2340

[Vladimir Rutsky]

On Fri, Feb 5, 2016 at 3:33 AM, Dustin J. Mitchell <dustin at v.igoro.us> wrote:
> I believe we actually use the twisted deprecation machinery in some places?

Yes, I found only single place:
https://github.com/buildbot/buildbot/blob/fd60481f0e0bde51185388b90be2b3cde88e62ba/master/buildbot/steps/shell.py#L353

>
> As to the cons --
>
> Twisted has been using this functionality for a while, with no ill effects.
> Changes to reloading should not affect users.  The performance impact should
> be minimal after startup . Since this is a relatively temporary change, I'm
> not worried about scaling.  And buildbot itself doesn't use star imports --
> user code really shouldn't either.
>
> Dustin

Ok, then I'll use module wrapping approach (using Twisted's
deprecatedModuleAttribute()).


Thanks,

Vladimir