[Buildbot-devel] Is this a 'bug' from MailNotifier in the new Reporter system?

[Francesco Di Mizio]

I noticed that the source of the Owners property always gets set to the
reason, even when a build is kicked with a force scheduler. I guess this is
not intended.

On Tue, May 19, 2015 at 3:35 PM, Francesco Di Mizio <
francescodimizio at gmail.com> wrote:

> After checking the code of getResponsibleUsersForBuild I ended up setting
> the owner property to the patch author to work around the problem. It looks
> like in this specifi case the issue wouldn't have existed if MailNotifier
> had been using getResponsibleUsersForSourceStamp instead of getResponsibleUsersForBuild.
> checking Not sure that would be the general solution though, I doubt it.
>
> In addition, setting the owner property myself caused Buildbot to set an
> other property called Owners which is just a a list with the only element
> being owner itself. Very funny thing is that the *Source of the Owners
> property is the reason I passed in to addBuildsetForSourceStamps*
>
>
> On Tue, May 19, 2015 at 3:07 PM, Francesco Di Mizio <
> francescodimizio at gmail.com> wrote:
>
>> Hello guys,
>>
>> I've got latest code along with the new Reporter system.
>>
>> In my custom code i am calling addBuildsetForSourceStamps passing in a
>> reason and  a sourcestamp containing a patch, a patch body and the author
>> of the patch.
>>
>> I then set up a MailNotifier with sendToInterestedUsers=True. I am now
>> receiving those emails. The patch (or patches in case buildSummary = True
>> is used) get attached. The build links have been fixed. In general it looks
>> good besided the following  :
>>
>> Build Reason: <unknown>
>>
>> Blamelist:
>>
>> Before Blamelist used to be the author of the patch and reason the reason
>> passed in to addBuildsetForSourceStamps. Note that Blamelist being empty
>> causes the author of the patch not to get the email.
>>
>> Should I file a bug or?
>>
>> Cheers,
>>
>>  Francesco
>>
>>
>>
>>
>>
>>
>>
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://buildbot.net/pipermail/devel/attachments/20150520/32e4d03e/attachment.html>