[Buildbot-devel] Submitting a PR for bitbucket change hook
Mikhail Sobolev
mss at mawhrin.net
Mon Mar 9 17:02:04 UTC 2015
Hi Brian,
On Mon, Mar 09, 2015 at 12:29:09PM -0400, Brian Lalor wrote:
> I did some work this morning on the bitbucket change hook to get it to
> include the branch name for all git commits. That information has to be
> inferred because their payload is pretty lacking. Anyway, I’ve done that
> against the 0.8.10 tag. It looks like the hook still lives on master (I
> thought that was getting refactored?). How should I submit the PR? Against
> the eight branch or against master? Will someone backport it to eight if I
> submit to master? Should I submit two PRs?
The current situation is that change hooks on master are not exactly
functional: the code for hooks is there, but the dispatcher is not.
My suggestion is to submit a PR against eight (this can be tested not only by
included test cases, but on a live system). I will port the change to master.
--
Misha
More information about the devel
mailing list