[Buildbot-devel] warnOnWarnings from Trigger build step

[Barry Laffoy]

Hi again

Could you offer some more guidance, please? I've backported the changes to
the head of eight here:
https://github.com/tensorproduct/buildbot/commit/792d68c5305a7f6471545feed2dbd012151dd670

I think that the relevant change is the worstStatus method, that looks at
the value of rclist, returned by the deferred schedulers.

However, on testing this, rclist doesn't seem to pick up a status of
WARNINGS(=1), but it does pickup SUCCESS(=0) and FAILURE(=2).

On a success of the triggered job "test-builder":
rclist = [(True, (0, {'test-builder': 989}))]

On a warning:
rclist = [(True, (0, {'test-builder': 992}))]

And on a failure:
rclist = [(True, (2, {'test-builder': 995}))]

where rclist[0][1][0] is the return code (I think) of the TriggerableScheduler.

I don't understand twisted.defer well enough to figure out where this
return value is being set, or why failures get through, but warnings
don't. Any pointers?

Thanks
Barry




On Wed, Feb 4, 2015 at 9:56 PM, Barry Laffoy <laffoyb at gmail.com> wrote:

> Cheers. Will do.
>
> On Wed, Feb 4, 2015 at 10:20 AM, Pierre Tardy <tardyp at gmail.com> wrote:
>
>>
>>
>> Le Wed Feb 04 2015 at 9:52:30 AM, Barry Laffoy <laffoyb at gmail.com> a
>> écrit :
>>
>>> Hi
>>>
>>> (Apologies if this is the wrong place for this sort of question.)
>>>
>>
>> Yes, its the good place.
>>
>>
>>>
>>> I have two two types of builders: Release and Test. Release builds my
>>> projects, triggers Test to test them, and then releases them (to an
>>> internal devpi server).
>>>
>>> I would like for the release to only happen if all the tests pass. Also,
>>> I would like for failing tests to set the status of the Test build to
>>> Warnings (as distinct from Failure).
>>> [..]
>>>
>>>
>>> Is there a reason that the Trigger build step doesn't warn on warnings
>>> of the child build? Have I misunderstood how this should work?
>>>
>> No, there is no good reason.
>>
>> Actually, this is fixed in master branch (aka nine)
>>
>> https://github.com/buildbot/buildbot/blob/master/master/buildbot/steps/trigger.py#L137
>>
>> You can try and backport that capability to eight branch.
>> The code is around here:
>>
>> https://github.com/buildbot/buildbot/blob/eight/master/buildbot/steps/trigger.py#L173
>>
>> https://github.com/buildbot/buildbot/blob/eight/master/buildbot/steps/trigger.py#L194
>> You can easily replace this code by the one in master branch (and send a
>> PR!)
>>
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://buildbot.net/pipermail/devel/attachments/20150205/eda249e3/attachment.html>