[Buildbot-devel] Trouble with addSuppression()

Vadim Zeitlin vz-buildbot at zeitlins.org
Wed Apr 15 22:22:57 UTC 2015

On Wed, 15 Apr 2015 20:41:17 +0300 Mikhail Sobolev <mss at mawhrin.net> wrote:

MS> On Wed, Apr 15, 2015 at 05:25:13PM +0200, Vadim Zeitlin wrote:
MS> >     step.addSuppression([
MS> You actually need to create a new class based on what operation you'd
MS> like to perform (Compile in this particular case) and override the
MS> method:

 Thanks for your reply, but unfortunately I remain completely confused. Do
I misunderstand the purpose of this method entirely? I thought I could use
it to specify the warnings to ignore/suppress in the buildbot master
configuration itself, is this wrong?

MS> class MyCompile(Compile):
MS>     def addSuppression(self, supp_list):
MS>         ...
MS> Please check implementation details[1] for how exactly this method
MS> should behave.
MS> [1] https://github.com/buildbot/buildbot/blob/eight/master/buildbot/steps/shell.py#L435

 I've been reading this code (and even sprinkling it with log.msg()
calls...) for quite some time already, but I still don't understand why/how
would I override the addSuppression() method. Its default implementation
seems perfectly fine to me, so what else would my overridden version do
other than calling the superclass version?

 Again, I'm probably missing something painfully obvious here, so perhaps I
should restate what I'm trying to do: instead of using "suppressionFile"
parameter of steps.Compile class, and then have to manage several different
suppressions for the different platforms/compilers in the main repository,
I'd rather just keep all this inside master.cfg itself. So I hoped to just
call addSuppression() directly when building the factory instead of putting
suppressions into a suppression file. Was this totally misguided?

 Thanks again for your help!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 196 bytes
Desc: not available
URL: <http://buildbot.net/pipermail/devel/attachments/20150416/f0b4252c/attachment.bin>

More information about the devel mailing list