[Buildbot-devel] Extra properties on forced rebuild

[Mikhail Sobolev]

On Thu, Nov 20, 2014 at 11:31:15AM +0000, Bruce Stephens wrote:
> Bruce Stephens <bruce.stephens at isode.com> writes:
> 
> [...]
> 
> > With the assistance of quite a few log.msg calls, here's how to do it:
> 
> I forgot a critical step.  There's a bug in 0.8.9:
> 
> diff --git a/master/buildbot/process/builder.py b/master/buildbot/process/builder.py
> index 0adf105..4f549c4 100644
> --- a/master/buildbot/process/builder.py
> +++ b/master/buildbot/process/builder.py
> @@ -581,7 +581,7 @@ class BuilderControl:
>          properties = Properties()
>          # Don't include runtime-set properties in a rebuild request
>          properties.updateFromPropertiesNoRuntime(bs.getProperties())
> -        if extraProperties is None:
> +        if extraProperties is not None:
>              properties.updateFromProperties(extraProperties)
>  
>          properties_dict = dict((k, (v, s)) for (k, v, s) in properties.asList())
> 
> 
> [...]
Thank you, Bruce.

I just submitted a PR to fix it in eight:

    https://github.com/buildbot/buildbot/pull/1372

Please let me know if you'd like the commit be attributed to you (I can
easily change the author).

-- 
Misha