[Buildbot-devel] Trigger steps should be able to extract properties from the triggered build

[yasser.lebon]

I made a fix for the issue http://trac.buildbot.net/ticket/2167 .

https://github.com/madazone/buildbot/tree/extract-triggered-build-properties

Feel free to make a review. 

Regards,
Yasser



On 17 Mar 2014, at 16:42, Yasser LEBON <yasser.lebon at gmail.com> wrote:

> I planned to use the status API at the beginning but I think I will need time to understand how does it work.
> 
>  Using JSON is another alternative but I didn't find any way to get a build properties. 
> 
> Regards,
> Yasser
> 
> 
> 2014-03-17 16:26 GMT+01:00 Vasily <vasslitvinov at pisem.net>:
> Hi Pierre,
> 
> While accessing status API is certainly more straighforward, my impression of 0.8 API is that working via JSON might be easier to understand... especially if one is a newcomer and doesn't know status API well enough (e.g. like me in some cases).
> 
> Thanks,
> Vasily
> 
> 
> 2014-03-17 17:23 GMT+04:00 Pierre Tardy <tardyp at gmail.com>:
> well query json, is a bit hacky indeed.
> 
> You can just access the status API in your subclassed Trigger. trigger.py is already doing something like this to get the build urls.
> 
> The problem is that trigger.py is not very well factorized to allow easy subclass customization.
> This is much better in nine branch.
> 
> 
> 
> Pierre
> 
> 
> On Mon, Mar 17, 2014 at 2:14 PM, Vasily <vasslitvinov at pisem.net> wrote:
> Hi Yasser,
> 
> I can suggest a dumb, but probably working way - you can subclass Trigger() and query e.g. Buidbot JSON interface to get the list of properties defined by triggered build.
> That is certainly |working backwards" to how Buildbot is designed, but that may lead you somewhere.
> 
> Thanks,
> Vasily
> 
> 
> 2014-03-17 15:40 GMT+04:00 Yasser LEBON <yasser.lebon at gmail.com>:
> Hi all, 
> 
> Until the following problem is resolved, does someone know how to work round the following  problem http://trac.buildbot.net/ticket/2167 ? Thanks.
> 
> 
> Yasser
> 
> 
> ------------------------------------------------------------------------------
> Learn Graph Databases - Download FREE O'Reilly Book
> "Graph Databases" is the definitive new guide to graph databases and their
> applications. Written by three acclaimed leaders in the field,
> this first edition is now available. Download your free book today!
> http://p.sfnet/sfu/13534_NeoTech
> 
> _______________________________________________
> Buildbot-devel mailing list
> Buildbot-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/buildbot-devel
> 
> 
> 
> ------------------------------------------------------------------------------
> Learn Graph Databases - Download FREE O'Reilly Book
> "Graph Databases" is the definitive new guide to graph databases and their
> applications. Written by three acclaimed leaders in the field,
> this first edition is now available. Download your free book today!
> http://p.sfnet/sfu/13534_NeoTech
> 
> _______________________________________________
> Buildbot-devel mailing list
> Buildbot-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/buildbot-devel
> 
> 
> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://buildbot.net/pipermail/devel/attachments/20140318/ffe30a88/attachment.html>