[Buildbot-devel] problem logging into trac.buildbot.net after password reset (and bug report)

[Philippe McLean]

thank you!
What release did that fix make it into?


On Fri, Jan 3, 2014 at 11:12 AM, Dustin J. Mitchell <dustin at v.igoro.us>wrote:

> That should be fixed up now.  Sorry :(
>
> And I'll save you the trouble of a bug: Ernie Hershey already fixed that
> typo:
>
> commit 81c97c82cf33cbb52a530cabcf7d3cf237ccda07
> Author: Ernie Hershey <github at ernie.org>
> Date:   Tue May 14 18:17:02 2013 -0300
>
>     Fix minor typo in INVALID EMAIL log msg
>
> diff --git a/master/buildbot/status/mail.py
> b/master/buildbot/status/mail.py
> index ef48d8e..30a5791 100644
> --- a/master/buildbot/status/mail.py
> +++ b/master/buildbot/status/mail.py
> @@ -742,17 +742,17 @@ class MailNotifier(base.StatusReceiverMultiService):
>              # Git can give emails like 'User' <user at foo.com>@foo.com so
> check
>              # for two @ and chop the last
>              if r.count('@') > 1:
>                  r = r[:r.rindex('@')]
>
>              if VALID_EMAIL.search(r):
>                  to_recipients.add(r)
>              else:
> -                twlog.msg("INVALID EMAIL: %r" + r)
> +                twlog.msg("INVALID EMAIL: %r" % r)
>
>          # If we're sending to interested users put the extras in the
>          # CC list so they can tell if they are also interested in the
>          # change:
>          if self.sendToInterestedUsers and to_recipients:
>              cc_recipients.update(self.extraRecipients)
>          else:
>              to_recipients.update(self.extraRecipients)
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://buildbot.net/pipermail/devel/attachments/20140103/3e26d5de/attachment.html>