[Buildbot-devel] problem logging into trac.buildbot.net after password reset (and bug report)

[Philippe McLean]

Hi,

I went to report a bug at trac.buildbot.net. I reset my password and
attempted to log in with the new password. trac.buildbot.net/login returned
an error:

"

TracError: The password file could not be updated. Trac requires
                    read and write access to both the password file
                    and its parent directory."

The bug I wanted to report is in buildbot master 0.8.8 on line 798 of
buildbot/status/mail.py, it seems that it should be a , not a +:


    def _gotRecipients(self, rlist, m):

...

            if VALID_EMAIL.search(r):


                to_recipients.add(r)

            else:

                twlog.msg("INVALID EMAIL: %r" + r)


this has resulted in log messages like:


2014-01-03 10:49:49-0800 [-] INVALID EMAIL: %r at XXXXX.com


2014-01-03 10:49:49-0800 [-] sending mail (772 bytes) to []

2014-01-03 10:49:49-0800 [-] Starting factory
<twisted.mail.smtp.ESMTPSenderFactory instance at 0x60dd9e0>

2014-01-03 10:49:49-0800 [-]  setting expectations for next time

2014-01-03 10:49:49-0800 [-] new expectations: 1356.8022635 seconds

2014-01-03 10:49:49-0800 [-] releaseLocks(<BuildSlave 'BUILDBOT31'>): []

2014-01-03 10:49:50-0800 [ESMTPSender,client] Unhandled error in Deferred:

2014-01-03 10:49:50-0800 [ESMTPSender,client] Unhandled Error

        Traceback (most recent call last):

        Failure: twisted.mail.smtp.SMTPDeliveryError: No recipients accepted

        >>> MAIL FROM:<buildbot at XXXXX.com>

        <<< 250 2.1.0 OK qp15sm110561311pbb.2 - gsmtp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://buildbot.net/pipermail/devel/attachments/20140103/753a33f8/attachment.html>